Tutorial Updates #2051
Merged
Tutorial Updates #2051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
--- Commit: ember-learn/super-rentals-tutorial@52a367d Script: https://github.com/ember-learn/super-rentals-tutorial/blob/52a367d4067008f3f854bf3ca0b5485e1610c396/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/52a367d4067008f3f854bf3ca0b5485e1610c396/checks
✅ Deploy Preview for ember-guides ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jaredgalanis
approved these changes
Aug 23, 2024
--- Commit: ember-learn/super-rentals-tutorial@a5132bc Script: https://github.com/ember-learn/super-rentals-tutorial/blob/a5132bc00ad27196f28e10cce9c1e9dece1660d1/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/a5132bc00ad27196f28e10cce9c1e9dece1660d1/checks
--- Commit: ember-learn/super-rentals-tutorial@a5132bc Script: https://github.com/ember-learn/super-rentals-tutorial/blob/a5132bc00ad27196f28e10cce9c1e9dece1660d1/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/a5132bc00ad27196f28e10cce9c1e9dece1660d1/checks
--- Commit: ember-learn/super-rentals-tutorial@e076a15 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/e076a153d94e7392fc9657461b261f339e498aef/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/e076a153d94e7392fc9657461b261f339e498aef/checks
--- Commit: ember-learn/super-rentals-tutorial@e076a15 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/e076a153d94e7392fc9657461b261f339e498aef/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/e076a153d94e7392fc9657461b261f339e498aef/checks
--- Commit: ember-learn/super-rentals-tutorial@e076a15 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/e076a153d94e7392fc9657461b261f339e498aef/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/e076a153d94e7392fc9657461b261f339e498aef/checks
--- Commit: ember-learn/super-rentals-tutorial@e076a15 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/e076a153d94e7392fc9657461b261f339e498aef/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/e076a153d94e7392fc9657461b261f339e498aef/checks
--- Commit: ember-learn/super-rentals-tutorial@e076a15 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/e076a153d94e7392fc9657461b261f339e498aef/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/e076a153d94e7392fc9657461b261f339e498aef/checks
--- Commit: ember-learn/super-rentals-tutorial@e076a15 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/e076a153d94e7392fc9657461b261f339e498aef/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/e076a153d94e7392fc9657461b261f339e498aef/checks
--- Commit: ember-learn/super-rentals-tutorial@e076a15 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/e076a153d94e7392fc9657461b261f339e498aef/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/e076a153d94e7392fc9657461b261f339e498aef/checks
--- Commit: ember-learn/super-rentals-tutorial@e076a15 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/e076a153d94e7392fc9657461b261f339e498aef/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/e076a153d94e7392fc9657461b261f339e498aef/checks
--- Commit: ember-learn/super-rentals-tutorial@e076a15 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/e076a153d94e7392fc9657461b261f339e498aef/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/e076a153d94e7392fc9657461b261f339e498aef/checks
--- Commit: ember-learn/super-rentals-tutorial@e076a15 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/e076a153d94e7392fc9657461b261f339e498aef/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/e076a153d94e7392fc9657461b261f339e498aef/checks
--- Commit: ember-learn/super-rentals-tutorial@e076a15 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/e076a153d94e7392fc9657461b261f339e498aef/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/e076a153d94e7392fc9657461b261f339e498aef/checks
--- Commit: ember-learn/super-rentals-tutorial@e076a15 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/e076a153d94e7392fc9657461b261f339e498aef/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/e076a153d94e7392fc9657461b261f339e498aef/checks
--- Commit: ember-learn/super-rentals-tutorial@e076a15 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/e076a153d94e7392fc9657461b261f339e498aef/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/e076a153d94e7392fc9657461b261f339e498aef/checks
IgnaceMaes
approved these changes
Sep 22, 2024
--- Commit: ember-learn/super-rentals-tutorial@e076a15 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/e076a153d94e7392fc9657461b261f339e498aef/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/e076a153d94e7392fc9657461b261f339e498aef/checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to let you know there are new content available for the tutorial!
If these changes look good to you, it is recommended that you merge the PR using the Squash and merge feature.
If there are any issues with the content here, do not edit these files directly – the original source lives in the super-rentals-tutorial repo.
Feel free to hold off on merging this PR and file an issue/PR in the upstream repo. After fixing the issues there, the upstream CI job will push the changes to this pull request branch, automatically, so you should see the changes reflected in this PR shortly after.
That being said, it's totally okay to push other changes to the
super-rentals-tutorialbranch manually, like making changes to the TOC or adding words to the dictionary. Just don't edit the markdown files themselves, since any changes you make will be wiped out by the next upstream CI job.You can rebase the branch and force-push, or even delete it! The CI job clones the branch fresh on each build, and re-creates it from the master branch if needed, so there shouldn't be any issues with conflicts and such.