Auto Notch #785
Draft
Auto Notch #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nerdCopter
force-pushed
the
emuflight-1.0.0-master
branch
from
07ddd2b
to
7015291
Compare
nerdCopter
force-pushed
the
20220329_cherry_pick_Auto_Notch
branch
from
cd308b0
to
ceaee39
Compare
nerdCopter
force-pushed
the
emuflight-1.0.0-master
branch
from
7015291
to
4a922e6
Compare
nerdCopter
force-pushed
the
20220329_cherry_pick_Auto_Notch
branch
from
ceaee39
to
511c079
Compare
nerdCopter
force-pushed
the
emuflight-1.0.0-master
branch
from
4a922e6
to
64a1957
Compare
nerdCopter
force-pushed
the
20220329_cherry_pick_Auto_Notch
branch
from
511c079
to
217eaf9
Compare
nerdCopter
force-pushed
the
emuflight-1.0.0-master
branch
2 times, most recently
from
0c4ee8b
to
3aab740
Compare
nerdCopter
force-pushed
the
20220329_cherry_pick_Auto_Notch
branch
from
217eaf9
to
7561e98
Compare
nerdCopter
force-pushed
the
emuflight-1.0.0-master
branch
from
3aab740
to
e86e758
Compare
nerdCopter
force-pushed
the
20220329_cherry_pick_Auto_Notch
branch
from
7561e98
to
a87fd2c
Compare
nerdCopter
force-pushed
the
emuflight-1.0.0-master
branch
2 times, most recently
from
fe70257
to
fe7710c
Compare
nerdCopter
force-pushed
the
20220329_cherry_pick_Auto_Notch
branch
from
a87fd2c
to
0ee1886
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autonotch is code that automatically decides how much the notch filter is crossfaded with its input signal. By determining the amount of noise at the notch frequency we can set up a limit. As noise approaches that limit the notch filter is used more, as noise is low it isn't used. This will automatically phase out rpm and dynamic notch filters that to do not have much use. This should reduce delay and turn off the effect of notch filters that are doing nothing.To test you have new rpm_noise_limit, and dyn_notch_noise_limit, both of which determine how much noise can pass through before the notch filter is fully turned on. A higher value allows more noise to pass through before the notch filter takes full effect, smaller values happen sooner.