Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow (multi_value : Table) : Column to succeed #11482

Closed
JaroslavTulach opened this issue Nov 4, 2024 · 20 comments · Fixed by #11600
Closed

Allow (multi_value : Table) : Column to succeed #11482

JaroslavTulach opened this issue Nov 4, 2024 · 20 comments · Fixed by #11600
Assignees
@JaroslavTulach
Labels
-compiler

Comments

@JaroslavTulach
Copy link
Member

The decision to support

and especially handle the Treat single column Table as a Column request, we are going to use multi values representing multiple types at once.

Multi value & type check

When the library code needs, it can create a multi value representing both Table and Column at once. However, when there is a return value check like -> Table - such a value would be converted to just a table. That shall no longer be the case - we need multi values to pass thru. A solution for this has already been provided once:

However such a solution worked poorly with potential static analysis.

Solution

The goal of this PR is to split the intersection type of an EnsoMultiValue into two parts:

  • the type checked one - a list of types whose methods are made available
  • the convertible one - a set of types this value can be converted ("cast") to
@github-project-automation github-project-automation bot moved this to ❓New in Issues Board Nov 4, 2024
@JaroslavTulach JaroslavTulach mentioned this issue Nov 4, 2024
Merged
2 tasks
@JaroslavTulach JaroslavTulach self-assigned this Nov 5, 2024
@JaroslavTulach JaroslavTulach mentioned this issue Nov 11, 2024
Merged
4 tasks
@enso-bot
Copy link

enso-bot bot commented Nov 12, 2024

Jaroslav Tulach reports a new STANDUP for yesterday (2024-11-11):

Progress: .

Next Day: Being at javadays.cz conference

@enso-bot
Copy link

enso-bot bot commented Nov 13, 2024

Jaroslav Tulach reports a new STANDUP for yesterday (2024-11-12):

Progress: .

Next Day: Next day I will be working on the #11482 task. Delivering Enso talk at javadays.cz conference

@enso-bot
Copy link

enso-bot bot commented Nov 14, 2024

Jaroslav Tulach reports a new STANDUP for yesterday (2024-11-13):

Progress: .

  • presentation about Enso at JavaDays.cz
  • everybody impressed
  • everybody loves the UI.
  • 2 people would like to design a pipeline for their Java library in the IDE
  • they want to call the resulting program from their Java program
  • some want to find duplicities in Excel sheets - e.g. expert Excel users It should be finished by 2024-11-18.

Next Day: Next day I will be working on the #11482 task. Back to work

@enso-bot
Copy link

enso-bot bot commented Nov 15, 2024 •
edited by unfurl-links bot
Loading

Jaroslav Tulach reports a new STANDUP for yesterday (2024-11-14):

Progress: .

Next Day: Finish type check refactoring, then up to

GitHub
Blocks #11468 Pull Request Description This PR implements the Truffle contract that all the Enso objects must export hasLanguage and getLanguage messages. By refactoring EnsoObject from an interfac...

@enso-bot
Copy link

enso-bot bot commented Nov 16, 2024 •
edited by unfurl-links bot
Loading

Jaroslav Tulach reports a new STANDUP for yesterday (2024-11-15):

Progress: .

GitHub
Blocks #11468 Pull Request Description This PR implements the Truffle contract that all the Enso objects must export hasLanguage and getLanguage messages. By refactoring EnsoObject from an interfac...

@enso-bot
Copy link

enso-bot bot commented Nov 19, 2024

Jaroslav Tulach reports a new STANDUP for yesterday (2024-11-18):

Progress: .

mergify bot pushed a commit that referenced this issue Nov 19, 2024
@JaroslavTulach
Multi value Complex test and robustness refactoring (#11525)
3d8a0e1 
While working on #11482 and enhancing the tests suite with more tests based on `type Complex` a [getRootNode() did not terminate in 100000 iterations](#11525 (comment)) problem was discovered. Detailed investigation revealed that the existing `ReadArgumentCheckNode` infrastructure was able to create a **cycle** of parent pointers in the Truffle AST.

The problem was in intricate manipulation of the AST while rewriting internals in `ReadArgumentCheckNode`. This PR avoids such manipulation by _refactoring the type checking code_. `ReadArgumentNode` knows nothing about types anymore. When a type check is needed, `IrToTruffle` adds additional `TypeCheckValueNode.wrap` around the `ReadArgumentNode` - that breaks the **vicious circle**.

All the _type checks_ nodes are moved to its own package. All but one of the classes are made package private. The external API for doing _type checking_ is concentrated into `TypeCheckValueNode`.
@enso-bot
Copy link

enso-bot bot commented Nov 20, 2024

Jaroslav Tulach reports a new STANDUP for yesterday (2024-11-19):

Progress: .

@enso-bot
Copy link

enso-bot bot commented Nov 21, 2024 •
edited by unfurl-links bot
Loading

Jaroslav Tulach reports a new STANDUP for yesterday (2024-11-20):

Progress: .

Discord
Discord is great for playing games and chilling with friends, or even building a worldwide community. Customize your own space to talk, play, and hang out.

somebody1234 pushed a commit that referenced this issue Nov 21, 2024
@JaroslavTulach @somebody1234
Multi value Complex test and robustness refactoring (#11525)
73b93f5 
While working on #11482 and enhancing the tests suite with more tests based on `type Complex` a [getRootNode() did not terminate in 100000 iterations](#11525 (comment)) problem was discovered. Detailed investigation revealed that the existing `ReadArgumentCheckNode` infrastructure was able to create a **cycle** of parent pointers in the Truffle AST.

The problem was in intricate manipulation of the AST while rewriting internals in `ReadArgumentCheckNode`. This PR avoids such manipulation by _refactoring the type checking code_. `ReadArgumentNode` knows nothing about types anymore. When a type check is needed, `IrToTruffle` adds additional `TypeCheckValueNode.wrap` around the `ReadArgumentNode` - that breaks the **vicious circle**.

All the _type checks_ nodes are moved to its own package. All but one of the classes are made package private. The external API for doing _type checking_ is concentrated into `TypeCheckValueNode`.
@enso-bot
Copy link

enso-bot bot commented Nov 22, 2024 •
edited by unfurl-links bot
Loading

Jaroslav Tulach reports a new STANDUP for yesterday (2024-11-21):

Progress: .

GitHub
Pull Request Description To help address #11481 and to simplify extracting of type information from EnsoMultiValue, let's enrich the public method API of TypeOfNode and then enhance it to allow...

@enso-bot
Copy link

enso-bot bot commented Nov 23, 2024 •
edited by unfurl-links bot
Loading

Jaroslav Tulach reports a new STANDUP for yesterday (2024-11-22):

Progress: .

GitHub
Enso Analytics is a self-service data prep and analysis platform designed for data teams. - Pull requests · enso-org/enso

@JaroslavTulach JaroslavTulach mentioned this issue Nov 25, 2024
Merged
2 tasks
mergify bot pushed a commit that referenced this issue Nov 25, 2024
@JaroslavTulach
Avoid exposing EnsoMultiValue getters (#11642)
1cc3848 
Another step in the #11482 work. Avoid accessing internals of `EnsoMultiValue`. Use `TypeOfNode` methods (as provided by #11618) instead.
@enso-bot
Copy link

enso-bot bot commented Nov 26, 2024

Jaroslav Tulach reports a new STANDUP for yesterday (2024-11-25):

Progress: .

hubertp pushed a commit that referenced this issue Nov 26, 2024
@JaroslavTulach @hubertp
Avoid exposing EnsoMultiValue getters (#11642)
1ea4d1a 
Another step in the #11482 work. Avoid accessing internals of `EnsoMultiValue`. Use `TypeOfNode` methods (as provided by #11618) instead.
@JaroslavTulach JaroslavTulach linked a pull request Nov 27, 2024 that will close this issue
Intersection types & type checks #11600
Merged
4 tasks
@enso-bot
Copy link

enso-bot bot commented Nov 28, 2024 •
edited by unfurl-links bot
Loading

Jaroslav Tulach reports a new STANDUP for yesterday (2024-11-27):

Progress: .

GitHub
This uses #11577. It creates a reference to a value that is cleared on reload; this change detects this, and clears the cache. Checklist Please ensure that the following checklist has been satisfie...
GitHub
Closes #11326 Pull Request Description Mega passes converted to minipasses in Passes.globalTypingPasses group: 
  enso/engine/runtime-compiler/src/main/scala/org/enso/compiler/Passes.s...</div></blockquote>

@enso-bot
Copy link

enso-bot bot commented Nov 29, 2024 •
edited by unfurl-links bot
Loading

Jaroslav Tulach reports a new STANDUP for yesterday (2024-11-28):

Progress: .

GitHub
Pull Request Description Allows connection between refresh button and caches as requested by #11485:

please use Managed_Resource.new system_resource=True to create a reference that "can disap...

@enso-bot
Copy link

enso-bot bot commented Nov 29, 2024 •
edited by unfurl-links bot
Loading

Jaroslav Tulach reports a new STANDUP for today (2024-11-29):

Progress: .

Discord
Discord is great for playing games and chilling with friends, or even building a worldwide community. Customize your own space to talk, play, and hang out.

@enso-bot
Copy link

enso-bot bot commented Dec 5, 2024 •
edited by unfurl-links bot
Loading

Jaroslav Tulach reports a new STANDUP for yesterday (2024-12-04):

Progress: .

Enso Analytics Community
Day 4 - Advent of Code 2024

Thread for solution to day 4

GitHub
Closes #11498 Pull Request Description Introduces runtime-parser-processor annotation processor that processes interfaces annotated with @IRNode. Introduces these 3 new sbt projects:

runtime-parse...

@enso-bot
Copy link

enso-bot bot commented Dec 6, 2024 •
edited by unfurl-links bot
Loading

Jaroslav Tulach reports a new STANDUP for yesterday (2024-12-05):

Progress: .

Discord
Discord is great for playing games and chilling with friends, or even building a worldwide community. Customize your own space to talk, play, and hang out.
GitHub
Advent of Code 2024 in Enso. Contribute to JaroslavTulach/AOC-2024-Enso development by creating an account on GitHub.

@enso-bot
Copy link

enso-bot bot commented Dec 12, 2024

Jaroslav Tulach reports a new STANDUP for the last Tuesday (2024-12-10):

Progress: - opencv PR merged: #11807

@enso-bot
Copy link

enso-bot bot commented Dec 12, 2024

Jaroslav Tulach reports a new STANDUP for the last Monday (2024-12-09):

Progress: - 0.0.0-dev handling merged: #11805

@enso-bot
Copy link

enso-bot bot commented Dec 12, 2024

Jaroslav Tulach reports a new STANDUP for yesterday (2024-12-11):

Progress: - multi value docs: 7db299b

@mergify mergify bot closed this as completed in #11600 Dec 12, 2024
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Dec 12, 2024
@enso-bot
Copy link

enso-bot bot commented Dec 13, 2024

Jaroslav Tulach reports a new STANDUP for yesterday (2024-12-12):

Progress: - intersection types PR merged: #11600

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JaroslavTulach JaroslavTulach

Labels
-compiler
Projects
Issues Board
Status: 🟢 Accepted
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Intersection types & type checks enso-org/enso
1 participant
@JaroslavTulach