Avoid exposing EnsoMultiValue getters #11642
Merged
+95
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
added
the
CI: No changelog needed
JaroslavTulach
requested review from
4e6,
hubertp and
Akirathan
as code owners
JaroslavTulach
commented
Nov 25, 2024
| @@ -137,7 +137,7 @@ static UnresolvedSymbol toDisplayText(Object payload, IndirectInvokeMethodNode p | |||
| } | |||
| } catch (Error | Exception e) { | |||
| logger().atError().log("Cannot compute message for " + payload, e); | |||
| throw UnsupportedMessageException.create(e); | |||
| throw UnsupportedMessageException.create(e instanceof AbstractTruffleException ? e : null); | |||
There was a problem hiding this comment.
The c2f48f1 change should fix this error - e.g. regular UnsupportedMessageException without any connection to the e will be thrown. The actual e exception will only be sent to:
logger().atError().log("Cannot compute message for " + payload, e);will we find the stacktrace of the AssertionError e in the CI output?
hubertp
approved these changes
Nov 25, 2024
JaroslavTulach
added
the
CI: Ready to merge
hubertp
pushed a commit
that referenced
this pull request
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Another step in the #11482 work. Avoid accessing internals of
EnsoMultiValue. UseTypeOfNodemethods (as provided by #11618) instead.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,