Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drive bugs #11925

Open
wants to merge 20 commits into
base: develop
Choose a base branch
from
Open

Drive bugs #11925

wants to merge 20 commits into from
+2,105 −1,065

Conversation

MrFlashAccount
Copy link
Contributor

Pull Request Description

Closes: https://github.com/enso-org/cloud-v2/issues/1493

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@MrFlashAccount MrFlashAccount added CI: No changelog needed Do not require a changelog entry for this PR. g-dashboard labels Dec 19, 2024
@MrFlashAccount MrFlashAccount self-assigned this Dec 19, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 19, 2024 •
edited
Loading

🧪 Storybook is successfully deployed!

📊 Dashboard:

@MrFlashAccount MrFlashAccount force-pushed the wip/sergeigarin/drive-bugs branch from 7e3f0fe to c7af0cb Compare December 22, 2024 10:41
@MrFlashAccount MrFlashAccount changed the title [skip ci] Drive bugs Drive bugs [skip ci] Dec 22, 2024
@MrFlashAccount MrFlashAccount changed the title Drive bugs [skip ci] Drive bugs Dec 22, 2024
@MrFlashAccount MrFlashAccount marked this pull request as ready for review December 23, 2024 16:59
@PabloBuchu
Copy link
Contributor

  1. Wen to trash -> clicked Analytics in location -> ended up with minor styling glitch
Screenshot 2024-12-24 at 12 33 58
  1. Not sure if the location should be clickable. Can we have full path on hover?
  2. Remove from sidebar modal still says "remove local forlder from favourites"
Screenshot 2024-12-24 at 12 36 19
  1. Above modal Remove does nothing. The folder is still in the sidebar
  2. Recent location looks much nicer than trash one. Providing more information. Can we unify them?
Screenshot 2024-12-24 at 12 38 37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PabloBuchu PabloBuchu Awaiting requested review from PabloBuchu PabloBuchu is a code owner

@indiv0 indiv0 Awaiting requested review from indiv0 indiv0 is a code owner

@somebody1234 somebody1234 Awaiting requested review from somebody1234 somebody1234 is a code owner

@Frizi Frizi Awaiting requested review from Frizi Frizi is a code owner

@farmaazon farmaazon Awaiting requested review from farmaazon farmaazon is a code owner

@vitvakatu vitvakatu Awaiting requested review from vitvakatu vitvakatu is a code owner

@kazcw kazcw Awaiting requested review from kazcw kazcw is a code owner

@AdRiley AdRiley Awaiting requested review from AdRiley AdRiley is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@MrFlashAccount MrFlashAccount

Labels
CI: No changelog needed Do not require a changelog entry for this PR. g-dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MrFlashAccount @PabloBuchu