Enable the fetching of only the OCI descriptor #2220
+593
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arewm
force-pushed
the
enable-fetching-of-oci-descriptor
branch
from
dbc2510 to
ee8df44
Compare
arewm
force-pushed
the
enable-fetching-of-oci-descriptor
branch
from
ee8df44 to
5583a73
Compare
zregvart
approved these changes
Dec 16, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2220 +/- ##
==========================================
+ Coverage 72.42% 72.69% +0.27%
==========================================
Files 88 88
Lines 7539 7615 +76
==========================================
+ Hits 5460 5536 +76
Misses 2079 2079
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/ok-to-test |
zregvart
reviewed
Dec 18, 2024
|
/ok-to-test |
zregvart
approved these changes
Dec 20, 2024
|
Do a |
arewm
force-pushed
the
enable-fetching-of-oci-descriptor
branch
from
938e1f8 to
f2e2d19
Compare
Some OCI artifacts need to have a specific media type (i.e. they should only be an OCI image index or an OCI image manifest). In order to determine that with a single remote call, we can just get the descriptor and then check the mediaType of that object. Signed-off-by: arewm <arewm@users.noreply.github.com>
arewm
force-pushed
the
enable-fetching-of-oci-descriptor
branch
from
f2e2d19 to
88ce5a8
Compare
|
Thanks. Squashed and regenerated the docs. |
|
/ok-to-test |
zregvart
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some OCI artifacts need to have a specific media type (i.e. they should only be an OCI image index or an OCI image manifest). In order to determine that with a single remote call, we can just get the descriptor and then check the mediaType of that object.