all Uint8Array output in base64 #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mixmix
commented
Jul 4, 2024
mixmix
commented
Jul 4, 2024
mixmix
commented
Jul 18, 2024
Comment on lines
+14
to
+30
| if (typeof rawConfig !== 'string') return rawConfig | ||
| if (!rawConfig.startsWith('0x')) return rawConfig | ||
|
|
||
| const hex = rawConfig.slice(2) | ||
| const utf8 = Buffer.from(hex, 'hex').toString() | ||
| const output = JSON.parse(utf8) | ||
| Object.keys(output).forEach(key => { | ||
| output[key] = output[key].map(base64toHex) | ||
| }) | ||
|
|
||
| return output | ||
| } | ||
|
|
||
| function base64toHex (base64: string): string { | ||
| return Buffer.from(base64, 'base64').toString('hex') | ||
| } |
There was a problem hiding this comment.
This is a new feature.
NOTE: the program_config by default stores the addresses as base64, y'all asked for hex to make comparisons easier, so I've added that
mixmix
commented
Jul 18, 2024
| @@ -14,7 +20,7 @@ export function replacer (key, value) { | |||
| } | |||
|
|
|||
| export function print (...args) { | |||
| console.log(...args) | |||
| console.log(...args.map(arg => stringify(arg))) | |||
There was a problem hiding this comment.
this is the core change
by default, print now converts UInt8Array => base64 so that output is not spammed with walls of Ints
|
@mixmix fix conflict then bump Frankie |
|
@frankiebee ready for a review. This PR changed a little over time cos of other PRs 🤷 |
|
@rh0delta can you final review this |
rh0delta
approved these changes
Jul 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #162 - all Uint8Array output should be in base64