Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NayNay] Entropy Register + Unit Tests #167

Merged
merged 7 commits into from
Jul 16, 2024
Merged

[NayNay] Entropy Register + Unit Tests #167

merged 7 commits into from
Jul 16, 2024

Conversation

rh0delta
Copy link
Contributor

@rh0delta rh0delta commented Jul 11, 2024

  • added new register pure function
  • imported new types from sdk
  • added unit test for default register

closes #149

- added new register pure function
- imported new types from sdk
- added unit test for default register
@rh0delta rh0delta requested a review from frankiebee July 11, 2024 19:57
@rh0delta rh0delta linked an issue Jul 11, 2024 that may be closed by this pull request
mixmix
mixmix previously requested changes Jul 16, 2024
Copy link
Contributor

@mixmix mixmix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one change requested

General reflections

  • Love ❤️ 🔥 the simplicity and clarity of these pure functions. They're also easy to test = the right path
  • The flow/*/index.js functions now start to feel like the same boiler plate 🗃️ 🥱 with many of them
    • take config state in, use config to start entropy
    • why? surely it should just take entropy and that's all done a level higher for each flow

Different PR tho (if that could even work .. it's late here)

src/flows/register/register.ts Show resolved Hide resolved
@rh0delta
Copy link
Contributor Author

@mixmix this PR is ready for re-review

@rh0delta rh0delta requested a review from mixmix July 16, 2024 18:07
@rh0delta rh0delta dismissed mixmix’s stale review July 16, 2024 18:34

frankies gonna say its cool

src/common/masking.ts Outdated Show resolved Hide resolved
Co-authored-by: Frankie <frankie.diamond@gmail.com>
Copy link
Collaborator

@frankiebee frankiebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love tests!

@rh0delta rh0delta merged commit 9f946dc into dev Jul 16, 2024
1 check passed
@rh0delta rh0delta deleted the naynay/register branch July 16, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

register
3 participants