Mixmix/programs deploy #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rh0delta
reviewed
Jul 31, 2024
Co-authored-by: Nayyir Jutha <nayyir@entropy.xyz>
mixmix
commented
Aug 1, 2024
| t.equal(programsAfterRemove.length, 1, 'charlie has 1 less program') | ||
|
|
||
| t.end() | ||
| }) |
There was a problem hiding this comment.
Apologies I moved lines around. Essentially
- dropped the (IMO) unnecessary use of other variables for
tandrun("know your scope" is sufficient?) - broke up lines of tests into "phases" which are like
[action, query?, assertionOfChange, '\n']- this is totally a personal quirk of mine that I do to make tests easy to read for me 😬
rh0delta
approved these changes
Aug 1, 2024
|
I'll smoke test this now 👀 |
|
✔️ works
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends on #204 and
deployProgramTesting
Screenshots (if applicable)
Additional Context
NOTE I've introduced changes to the TUI
.wasmfile extentsionconfigutationSchemashould be installed and it's a.jsonfile extensionauxillaryDataSchemashould be installed and it's a.jsonfile extensionHave not smoke tested the TUI yet 🚬
Checklist
CHANGELOG.mdentry.github.com:entropyxyz/entropy-docs, where necessary.