Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixmix/programs deploy #206

Merged
merged 8 commits into from
Aug 1, 2024
Merged

Mixmix/programs deploy #206

merged 8 commits into from
Aug 1, 2024

Conversation

mixmix
Copy link
Contributor

@mixmix mixmix commented Jul 31, 2024

This PR extends on #204 and

  • extracts deployProgram
  • tests it
  • plugs it into TUI

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed

Screenshots (if applicable)

Additional Context

NOTE I've introduced changes to the TUI

  • assumes bytecode is a .wasm file extentsion
  • assumes a configutationSchema should be installed and it's a .json file extension
  • assumes an auxillaryDataSchema should be installed and it's a .json file extension

Have not smoke tested the TUI yet 🚬

Checklist

  • I have performed a self-review of my code.
  • I have added tests.
  • I have commented my code.
  • I have included a CHANGELOG.md entry.
  • I have updated documentation in github.com:entropyxyz/entropy-docs, where necessary.

@mixmix mixmix requested a review from rh0delta July 31, 2024 08:38
tests/programs.test.ts Outdated Show resolved Hide resolved
Base automatically changed from mixmix/programs_refactor to dev July 31, 2024 22:27
mixmix and others added 2 commits August 1, 2024 13:26
t.equal(programsAfterRemove.length, 1, 'charlie has 1 less program')

t.end()
})
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies I moved lines around. Essentially

  • dropped the (IMO) unnecessary use of other variables for t and run ("know your scope" is sufficient?)
  • broke up lines of tests into "phases" which are like [action, query?, assertionOfChange, '\n']
    • this is totally a personal quirk of mine that I do to make tests easy to read for me 😬

@mixmix mixmix requested a review from rh0delta August 1, 2024 01:47
@rh0delta rh0delta merged commit df36f05 into dev Aug 1, 2024
2 checks passed
@rh0delta rh0delta deleted the mixmix/programs_deploy branch August 1, 2024 01:59
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2024
@mixmix
Copy link
Contributor Author

mixmix commented Aug 1, 2024

I'll smoke test this now 👀

@mixmix
Copy link
Contributor Author

mixmix commented Aug 1, 2024

✔️ works

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants