Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NayNay] File Restructure: Faucet #225

Merged
merged 9 commits into from
Sep 24, 2024
Merged

[NayNay] File Restructure: Faucet #225

merged 9 commits into from
Sep 24, 2024

Conversation

rh0delta
Copy link
Contributor

Related Issue(s)

  • Resolves #[issue_number]

Proposed Changes

  • restructured faucet to match the new structure

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed

Screenshots (if applicable)

Additional Context

Checklist

  • I have performed a self-review of my code.
  • I have added tests.
  • I have commented my code.
  • I have included a CHANGELOG.md entry.
  • I have updated documentation in github.com:entropyxyz/entropy-docs, where necessary.

@rh0delta rh0delta marked this pull request as ready for review September 17, 2024 20:07
frankiebee
frankiebee requested changes Sep 17, 2024
View reviewed changes
src/faucet/interaction.ts Outdated Show resolved Hide resolved
src/faucet/interaction.ts Outdated Show resolved Hide resolved
src/faucet/interaction.ts Outdated Show resolved Hide resolved
src/faucet/main.ts Show resolved Hide resolved
src/faucet/main.ts Outdated Show resolved Hide resolved
src/faucet/main.ts Outdated Show resolved Hide resolved
src/faucet/main.ts Outdated Show resolved Hide resolved
src/faucet/main.ts Outdated Show resolved Hide resolved
frankiebee
frankiebee requested changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@frankiebee frankiebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried this out and it works!!! Looks great thanks! last things: changelog entry

@rh0delta rh0delta merged commit 54de68d into naynay/file-restructure Sep 24, 2024
2 checks passed
@rh0delta rh0delta deleted the naynay/faucet-restructure branch September 24, 2024 19:21
@github-actions github-actions bot locked and limited conversation to collaborators Sep 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frankiebee frankiebee frankiebee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rh0delta @frankiebee