fix cli opts bug with multiple accountOptions #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mixmix
commented
Oct 3, 2024
Comment on lines
-23
to
-24
| .addOption(accountOption()) | ||
| .addOption(endpointOption()) |
There was a problem hiding this comment.
THIS was a squirrely bug - tj/commander.js#2260
mixmix
commented
Oct 3, 2024
| selectedAccount: account | ||
| }) | ||
| } | ||
| .argParser(addressOrName => { |
There was a problem hiding this comment.
🐛 - this cannot be async!
See comments
mixmix
commented
Oct 3, 2024
Comment on lines
+76
to
+89
| export async function setSelectedAccount (account: EntropyAccountConfig, configPath = CONFIG_PATH) { | ||
| const storedConfig = await get(configPath) | ||
|
|
||
| if (storedConfig.selectedAccount === account.name) return storedConfig | ||
| // no need for update | ||
|
|
||
| const newConfig = { | ||
| ...storedConfig, | ||
| selectedAccount: account.name | ||
| } | ||
| await set(newConfig, configPath) | ||
| return newConfig | ||
| } | ||
|
|
There was a problem hiding this comment.
🔥 one bug I saw was inconsistent setting of config.selectedAccount as account.name OR account.address
I decided to fix it to be name because then in the --help you will see e.g (default: naynay) instead of (default: 0x12312231231232) 💀
I then changed
accountOptionto deal withname- added a special method
setSelectedAccountto handle the persistence of the right thing
Things I'm not happy about
1. repeated `config.get`... 2. this is all gonna be a pain when we want to add `-c, --config ` 3. `src/account/utils.js` still has hard-coded `config.set` for `selectedAccount` because... we need to persist the whole config anyway...
Merged
|
@mixmix you able to update this PR and rebase off of the current version of dev? can complete my full review after that's done. |
|
@rh0delta merged in |
rh0delta
approved these changes
Oct 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tiny PRs!