Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quieten down docker #425

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

quieten down docker #425

wants to merge 3 commits into from

Conversation

mixmix
Copy link
Collaborator

@mixmix mixmix commented Oct 22, 2024

Our tests are pretty spammy with docker spinning up / down.

This makes it a lot easier to see where "actual" tests are up to, and also for us to see that there is still logging coming out of substrate.

image

Base automatically changed from frankie/core#v0.3.0.rc-1 to main October 23, 2024 20:58
dev/bin/spin-up.sh Outdated Show resolved Hide resolved
docker compose --file dev/docker-scripts/four-nodes.yaml down 2> /dev/null
docker compose --file dev/docker-scripts/one-node-no-tss.yaml down 2> /dev/null
./dev/bin/spin-down.sh four-nodes
./dev/bin/spin-down.sh one-node-no-tss
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this works, but it adds a call docker compose --file "$FILE" logs 🤷

Comment on lines +6 to +14
spin_up() {
docker compose --file "$FILE" "$@" up --detach

if [ $? -ne 0 ]; then
echo "Error: 'docker compose up' failed."
echo "Retrying verbose:"
docker compose --file "$FILE" up --detach
fi
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this and here's how it looked when if fails (make it fail by editing ENTROPY_CORE_VERSION)

image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This assumes docker is good and exits with an exit code if it hit any problems...

@mixmix
Copy link
Collaborator Author

mixmix commented Oct 28, 2024

@frankiebee can review at leisure

@mixmix
Copy link
Collaborator Author

mixmix commented Oct 28, 2024

Frankie is gonna test how this behaves in CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant