Improve unhandled error copy (#17)

* improved unhandled and unexpected error messages * updated tests
envoy · Oct 2, 2018 · d0bea3b · d0bea3b
1 parent aa542ed
commit d0bea3b
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/index.js b/index.js
@@ -37,7 +37,7 @@ function Platform (config) {
 }
 Platform.prototype.handleError = function (event, e) {
   if (event.name === 'event' || (event.name === 'route' && this.req.job)) {
-    return this.res.job_fail('Unhandled Exception', e.message || 'Unhandled Exception', e)
+    return this.res.job_fail('Failed', e.message || 'unhandled_error', e)
   }
   if (event.name === 'route') {
     return this.res.error(e)

diff --git a/lib/response.js b/lib/response.js
@@ -72,7 +72,7 @@ Response = (function () {
   Response.prototype.job_fail = function (status, msg, data) {
     this.meta('set_job_status', 'failed')
     this.meta('set_job_status_message', status)
-    this.meta('set_job_failure_message', msg)
+    this.meta('set_job_failure_message', msg || 'unexpected_error')
     if (data) {
       this._respond(errorToObject(data))
     }

diff --git a/test/index.spec.js b/test/index.spec.js
@@ -227,7 +227,7 @@ describe('index', function () {
       expect(context.succeed).to.have.been.called()
       let args = context.succeed.args[0][0]
       expect(args.meta.set_job_status).to.equal('failed')
-      expect(args.meta.set_job_status_message).to.equal('Unhandled Exception')
+      expect(args.meta.set_job_status_message).to.equal('Failed')
       expect(args.meta.set_job_failure_message).to.equal('no')
       expect(args.body.message).to.equal('no')
     })
@@ -250,7 +250,7 @@ describe('index', function () {
           expect(context.succeed).to.have.been.called()
           let args = context.succeed.args[0][0]
           expect(args.meta.set_job_status).to.equal('failed')
-          expect(args.meta.set_job_status_message).to.equal('Unhandled Exception')
+          expect(args.meta.set_job_status_message).to.equal('Failed')
           expect(args.meta.set_job_failure_message).to.equal('no')
           expect(args.body.message).to.equal('no')
           done()