#1970 - New text entities in KET-format #2093
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderSavelyev
requested changes
Oct 9, 2024
| @@ -71,10 +71,38 @@ void printMappings(Array<int>& mapping) | |||
| } | |||
|
|
|||
| MoleculeJsonSaver::MoleculeJsonSaver(Output& output) | |||
| : _output(output), _pmol(nullptr), _pqmol(nullptr), add_stereo_desc(false), pretty_json(false), use_native_precision(false) | |||
There was a problem hiding this comment.
by default ket version 1 should be used in json saver
| writer.EndObject(); | ||
| } | ||
|
|
||
| void MoleculeJsonSaver::saveText(JsonWriter& writer, const KETTextObject& text_obj) |
There was a problem hiding this comment.
rename to saveTextV2
| @@ -639,6 +661,47 @@ void MoleculeCdxmlLoader::_parseCDXMLPage(BaseCDXElement& elem) | |||
| _has_scheme = true; | |||
| } | |||
| } | |||
| else if (page_elem->value() == "colortable") | |||
There was a problem hiding this comment.
add constant for colortable
| { | ||
| for (auto color_elem = page_elem->firstChildElement(); color_elem->hasContent(); color_elem = color_elem->nextSiblingElement()) | ||
| { | ||
| if (color_elem->name() == "color") |
There was a problem hiding this comment.
add constant for color
| for (auto color_prop = color_elem->firstProperty(); color_prop->hasContent(); color_prop = color_prop->next()) | ||
| { | ||
| auto cval = static_cast<int>(std::stof(color_prop->value()) * 0xFF); | ||
| if (color_prop->name() == "r") |
There was a problem hiding this comment.
add constant for r
| cdxml_color |= cval << 16; | ||
| else if (color_prop->name() == "g") | ||
| cdxml_color |= cval << 8; | ||
| else if (color_prop->name() == "b") |
There was a problem hiding this comment.
add constant for b
| } | ||
| } | ||
| } | ||
| else if (page_elem->value() == "fonttable") |
There was a problem hiding this comment.
add constnat font fonttable
| { | ||
| for (auto font_elem = page_elem->firstChildElement(); font_elem->hasContent(); font_elem = font_elem->nextSiblingElement()) | ||
| { | ||
| if (font_elem->name() == "font") |
There was a problem hiding this comment.
add constant for font
| { | ||
| std::string text_element = text_style->name(); | ||
| // "s" = parts | ||
| if (text_element == "s") |
| if (text_element == "s") | ||
| { | ||
| std::string style_text = text_style->getText(); | ||
| if (style_text == "+") |
AlexanderSavelyev
requested changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generic request
#1234 – issue name