Fix cothread version parsing to handle suffixes #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These suffixes are auto-generated from setuptools_scm, and are not usually just integers
mdavidsaver
reviewed
Nov 5, 2024
| # >= 2.16 will attempt to import this module | ||
| ver = tuple(int(c) for c in cothread.__version__.split(".")) |
There was a problem hiding this comment.
Since the first two (or three?) pieces will always be integers, maybe some slicing would be simpler?
ver = tuple(int(c) for c in cothread.__version__.split(".")[:2])There was a problem hiding this comment.
That is indeed much cleaner. Implemented in 811a856.
Suggested by Michael Davidsaver during review
AlexanderWells-diamond
force-pushed
the
fix_cothread_version_parsing
branch
from
aa19ac1
to
811a856
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These suffixes are auto-generated from setuptools_scm, and are not usually just integers. For example
2.20.1.dev1+g82e2778.d20241105is a valid version for Cothread. Such a version number is generated if you install from a Git checkout - see docs for detailsThis came up when attempting to create a pythonSoftIOC CI run that installed all of its dependencies directly from GitHub master branches - see this PR