Adding the AcTrig source options, making evr clock mode record, etc #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hongran , for this MR I would prefer to have the different changes on different commits (e.g.: one for the fix, another for adding the actrig source options). On that way we can revert things easily on the future. |
|
Yes. I will revert the branch to the version with the macro corrections only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I combined a few updates:
1: Adding more options to AcTrig source. Before it was a bo record for event clock or mxc7. we made it an mbbo record to support FP1 and FP2 options.
2: Adding a record for the EVR event clock mode
3: Corrected a typo in macro U32_EventLog(N)
4: Updated a few macros like
define PulserMax 24
define OutputCMLMax 4