-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate out Matern kernels #835
Conversation
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 8db04a5 is merged into main:
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 3e43cdb is merged into main:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks right to me based but I also convinced myself the other approach was correct so take that with a pinch of salt.
Co-authored-by: Sam Abbott <s.e.abbott12@gmail.com>
This is how benchmark results would change (along with a 95% confidence interval in relative change) if f8228d0 is merged into main:
|
Description
This PR closes #760 and #828.
It splits out spectral densities of Matern Kernels of order 1/2, 3/2 and 5/2.
It would be good for someone to check both the maths (which I've updated in the vignette) and code are correct.
Initial submission checklist
devtools::test()
anddevtools::check()
).devtools::document()
).lintr::lint_package()
).After the initial Pull Request