Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "tolerance" with "default_cdf_cutoff" in message #863

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

jamesmbaazam
Copy link
Contributor

Description

This PR closes #860 by replacing "tolerance" with "default_cdf_cutoff" in a message because it was a mistake.

Initial submission checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have tested my changes locally (using devtools::test() and devtools::check()).
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required and rebuilt docs if yes (using devtools::document()).
  • I have followed the established coding standards (and checked using lintr::lint_package()).
  • I have added a news item linked to this PR.

After the initial Pull Request

  • I have reviewed Checks for this PR and addressed any issues as far as I am able.

@jamesmbaazam
Copy link
Contributor Author

Is this NEWS worthy?

@sbfnk sbfnk added this pull request to the merge queue Nov 21, 2024
@sbfnk
Copy link
Contributor

sbfnk commented Nov 21, 2024

Is this NEWS worthy?

I think we can live without a news item in this case.

Merged via the queue into main with commit ad90863 Nov 21, 2024
9 checks passed
@sbfnk sbfnk deleted the issue-860 branch November 21, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reword "tolerance" to "default_cdf_cutoff" in message
2 participants