-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌍 Wrapping asio lib to create a custom network library (EPI-40) #10
Open
6im0n
wants to merge
14
commits into
develop
Choose a base branch
from
feature/epi-40-wrap-asio
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6im0n
requested review from
RenardFute,
AubaneNourry,
Marius-P1 and
landryarki
and removed request for
AubaneNourry
October 2, 2024 00:20
6im0n
added
enhancement
New feature or request
network
feature or issue related to the network side
labels
Oct 2, 2024
6im0n
changed the title
Feature/epi 40 wrap asio
🌍 Wrapping asio lib to create a custom network library (EPI-40)
Oct 2, 2024
landryarki
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant changes to the R-Type-Reborn project, focusing on adding network capabilities using the Asio library, restructuring the project, and providing documentation. Key changes include adding client-server network functionality, updating the build configuration, and including a detailed installation guide for
vcpkg
.Network Functionality:
src/network/client/Client.cpp
andsrc/network/client/Client.hpp
: Implemented aClient
class that handles connecting, sending, receiving, and disconnecting from a server using both TCP and UDP protocols. [1] [2]src/network/server/Server.cpp
andsrc/network/server/Server.hpp
: Implemented aServer
class that handles starting, stopping, sending, and receiving data, as well as managing client connections. [1] [2]Build Configuration:
CMakeLists.txt
: Updated the build configuration to include the Asio library and added subdirectories for network components.src/network/CMakeLists.txt
: Added CMake configuration for building the network library, including linking with Asio.Documentation: (outdated)
documentation/vcpkg_installation_guide.md
: Added a comprehensive guide for installingvcpkg
on Windows, Linux, and macOS.Code Cleanup:
src/main.cpp
: Removed the old main file and its associated code.src/CMakeLists.txt
: Removed outdated source references.Test Files:
tests/client/main.cpp
: Added a test client that demonstrates connecting to a server and sending a message.tests/server/main.cpp
: Added a test server that demonstrates starting the server and handling incoming connections.