optionally disable otel subchart, configure tracing endpoint, handle db secrets better #26
+23
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re the tracing endpoint
… typos in secret manifests
fishnix
changed the title
fishnix
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option to disable the inclusion of the otel subchart since you may not need to deploy the collector in cases where you disable tracing or you have another collector deployed outside of the chart. It also allows allows for configuration of the tracing endpoints for the governor-api deployment. Finally, it moves the governor db uri secret reference to an env value so it can reference different secret formats - this is especially useful if you're using something like cloudnative-pg which automatically writes out the db-ur into a secret.