-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MISFIT_PREPROCESSOR to ERT template #217
base: master
Are you sure you want to change the base?
Conversation
✔️ kmeans clustering has now been added equinor/semeio#286 🚫 currently still blocked by equinor/ert#1316 |
5bab7e1
to
9ca3e53
Compare
✔️ kmeans clustering has now been added equinor/semeio#286 ✔️ speed improvement for many observations equinor/ert#1316 |
🚫 Currently blocked by the new commits not yet being in pypi. |
Both packages are now updated on pypi (2.21.b0 and 1.0.b0) ✔️ Ready for testing. |
I have tested the
|
All in all, the only thing that I could infer from these output files is that 2 clusters of observations seem to be formed and assigned to calculated scaling factors based on some singular value decomposition or PCA (with 33 non-zero singular values). But it remains unclear why 2 clusters and how the singular values are used to determine the scaling factors. Another observation is that, when I ran it for the second time, I noticed differences in the output of To conclude: based on my tests done in the Norne example, I would not recommend to merge this PR branch to master before we understand better what this option is doing exactly and ensure that we can control any possible randomness associated with this process. If we do proceed with merging, my advice would be to expose this as an optional setting in FlowNet config file and make sure to have it disabled as default. The large number of FlowNet failing simulations when this option was enabled stopped me from determining whether or not this would be useful to mitigate the problem of having a very large number of observations in our FlowNet runs. |
This PR implements scaling of correlated observations using the ERT build-in PCA scaling method.
Contributor checklist
Add(On its way out - should useSTD_SCALE_CORRELATED_OBS TRUE
MISFIT_PREPROCESSOR
)MISFIT_PREPROCESSOR
asPRE_FIRST_UPDATE
hooked workflowCHANGELOG.md
.