Skip to content

Commit

Permalink
fix: Isolated k8s config files (#723)
Browse files Browse the repository at this point in the history
- [ ] New feature
- [x] Bug fix
- [ ] High impact

**Description of work:**
Isolated k8s config manifest files to each application to prevent them
overwriting eachother.


**Testing:**
- [ ] Can be tested
- [ ] Automatic tests created / updated
- [ ] Local tests are passing

Should inspect CI to see that the api is working and can load
secret/config as expected


**Checklist:**
- [ ] Considered automated tests
- [ ] Considered updating specification / documentation
- [ ] Considered work items 
- [ ] Considered security
- [ ] Performed developer testing
- [ ] Checklist finalized / ready for review
  • Loading branch information
HansDahle authored Nov 15, 2024
1 parent 75c7441 commit 7d41c0d
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions src/Fusion.Summary.Api/Deployment/k8s/deployment-service.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v1
kind: Secret
metadata:
name: env-secrets
name: summary-api-env-secrets
labels:
environment: {{ENVNAME}}
type: Opaque
Expand Down Expand Up @@ -36,7 +36,7 @@ spec:
volumes:
- name: env-secrets-volumes
secret:
secretName: env-secrets
secretName: summary-api-env-secrets

containers:
- name: summary-api
Expand Down
4 changes: 2 additions & 2 deletions src/Fusion.Summary.Api/Deployment/k8s/pr-deployment-env.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
apiVersion: v1
kind: Secret
metadata:
name: env-secrets
name: summary-api-env-secrets
labels:
environment: pr
type: Opaque
Expand Down Expand Up @@ -42,7 +42,7 @@ spec:
volumes:
- name: env-secrets-volumes
secret:
secretName: env-secrets
secretName: summary-api-env-secrets

containers:
- name: summary-api-pr-{{prNumber}}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v1
kind: Secret
metadata:
name: env-secrets
name: resources-api-env-secrets
labels:
environment: {{ENVNAME}}
type: Opaque
Expand Down Expand Up @@ -36,7 +36,7 @@ spec:
volumes:
- name: env-secrets-volumes
secret:
secretName: env-secrets
secretName: resources-api-env-secrets

containers:
- name: resources-api
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
apiVersion: v1
kind: Secret
metadata:
name: env-secrets
name: resources-api-env-secrets
labels:
environment: pr
type: Opaque
Expand Down Expand Up @@ -42,7 +42,7 @@ spec:
volumes:
- name: env-secrets-volumes
secret:
secretName: env-secrets
secretName: resources-api-env-secrets

containers:
- name: resources-api-pr-{{prNumber}}
Expand Down

0 comments on commit 7d41c0d

Please sign in to comment.