Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Do not set ProposedPerson = NULL when ResetWorkflow #594

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

aleklundeq
Copy link
Collaborator

  • New feature
  • Bug fix
  • High impact

Description of work:
When resetting workflow as a step in rejecting a AllocationRequest I have removed functionality to set ProposedPerson to NULL. This is an attempt to make ProposedPerson available when the task owner is responding to a rejected request, which should be to create a new request. It is then easier to know who was the previous suggested resource before creating a new request

Testing:

  • Can be tested
  • Automatic tests created / updated
  • Local tests are passing

Can be tested by creating a new request with a specific resource (as proposedPerson). Then the resource owner should reject the request. The rejected request should then still contain the proposedPerson suggested in the first step.

Checklist:

  • Considered automated tests
  • Considered updating specification / documentation
  • Considered work items
  • Considered security
  • Performed developer testing
  • Checklist finalized / ready for review

@aleklundeq aleklundeq changed the title feat/DoNotSetProposedPersonToNULLWhenResetWorkflow feat/Do not set ProposedPerson = NULL when ResetWorkflow Oct 2, 2023
@aleklundeq aleklundeq marked this pull request as ready for review October 2, 2023 18:31
@aleklundeq aleklundeq changed the title feat/Do not set ProposedPerson = NULL when ResetWorkflow feat: Do not set ProposedPerson = NULL when ResetWorkflow Oct 2, 2023
@aleklundeq aleklundeq merged commit 9b8e556 into master Oct 10, 2023
6 checks passed
@aleklundeq aleklundeq deleted the feat/dontRemoveProposedPersonWhenResetWorkflow branch October 10, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants