Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add diagnostics for algs exceeding max length #133

Closed
wants to merge 1 commit into from

Conversation

vetlek
Copy link
Collaborator

@vetlek vetlek commented May 8, 2023

Closes #122

@vetlek vetlek requested a review from einarsi May 8, 2023 12:47
@einarsi
Copy link
Collaborator

einarsi commented May 9, 2023

Will this not be invalid for all template files since they almost exclusively have calcs that include Jinja labels? E.g. the 14-character long {{ wellname }} will typically be replaced by three characters such as A09.
Is there a way to have a configuration setting where this is only performed on output files from scg? Either by checking the outfile key in the yaml config or by requiring the user to input the files in the project workspace for which the test should be performed? Or alternatively selecting paths for which this check should not be performed?

@vetlek vetlek marked this pull request as draft May 11, 2023 09:04
@einarsi
Copy link
Collaborator

einarsi commented Jun 22, 2023

Suggest to diagnose the length of the Alg only if it contains no Jinja expressions/labels. That way it should warn of issues for the final rendered file (and of course other standalone files).

@vetlek
Copy link
Collaborator Author

vetlek commented Aug 8, 2023

Closing. Will be addressed in #233

@vetlek vetlek closed this Aug 8, 2023
@vetlek vetlek deleted the alg_max_length branch April 9, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check max length of Alg
2 participants