Add ConfigurableFixerTrait to fix breaking changes from PHP-CS-Fixer
#13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickskrauch
requested changes
Jun 21, 2024
| @@ -17,7 +17,7 @@ | |||
| "homepage": "https://github.com/erickskrauch/php-cs-fixer-custom-fixers", | |||
| "require": { | |||
| "php": "^7.4 || ^8.0", | |||
| "friendsofphp/php-cs-fixer": "^3" | |||
| "friendsofphp/php-cs-fixer": "^3.59" | |||
There was a problem hiding this comment.
Seems like the ConfigurableFixerTrait has been introduced only on version 3.59.3. So you have to be more strict about it.
There was a problem hiding this comment.
I would ask you to check, that the dependencies can be installed on the PHP 7.4.
|
I apologize, I looked at the #14 and I like their solution better as it doesn't require raising the PHP-CS-Fixer requirement. But still, thank you so much for taking the time to create this PR! 🫶 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP-CS-Fixer recently introduced a breaking change in PHP-CS-Fixer/PHP-CS-Fixer#7988 which requires to add a new trait.