Support libsodium #383
Support libsodium #383
Conversation
zmq-sys/Cargo.toml
Outdated
| @@ -14,9 +14,11 @@ build = "build/main.rs" | |||
| links = "zmq" | |||
|
|
|||
| [features] | |||
| libsodium = ['libsodium-sys-stable'] | |||
There was a problem hiding this comment.
| libsodium = ['libsodium-sys-stable'] | |
| libsodium = ['dep:libsodium-sys-stable'] |
And shouldn't these be double quotes?
|
|
||
| [dependencies] | ||
| libc = "0.2.15" | ||
| libsodium-sys-stable = { version = "1.0", optional = true } |
There was a problem hiding this comment.
I think that 1.0 is not a valid version number for libsodium-sys-stable: https://crates.io/crates/libsodium-sys-stable/versions
Maybe change to the latest, 1.20.4? After changing the version value, I was able to set CURVE keys without errors being returned.
There was a problem hiding this comment.
Because of semver, 1.0 really means >=1.0.0, which includes 1.18.1 and above.
That said it might make sense to validate that things actually build with that version, with i.e. cargo +nightly -Zminimal-versions generate-lockfile.
There was a problem hiding this comment.
Ok, I was not aware of that, thanks for educating me!
I wonder why changing the version number to something explicitly in their version list seemed to make a difference on my local setup though? I can no longer recall how things were failing (build issues vs. issues with my runtime testing). I was pretty sure that this change actually resolved whatever the issue was, but perhaps I changed multiple things... I simply don't remember anymore.
Added a feature to support libsodium.
Fixes #357