Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optionally attach Coordinator to the view #19

Merged
merged 6 commits into from
Sep 19, 2023
Merged

Optionally attach Coordinator to the view #19

merged 6 commits into from
Sep 19, 2023

Conversation

erikdrobne
Copy link
Owner

@erikdrobne erikdrobne commented Sep 18, 2023 •
edited
Loading

  • Add attachCoordinator parameter to the NavigationRoute
  • This property indicates whether the Coordinator should be attached to the View as an EnvironmentObject.

@erikdrobne erikdrobne self-assigned this Sep 18, 2023
@erikdrobne erikdrobne added the enhancement New feature or request label Sep 18, 2023
@erikdrobne erikdrobne changed the title [WIP] Optionally attach Coordinator to the view Optionally attach Coordinator to the view Sep 18, 2023
@erikdrobne erikdrobne merged commit ec1096a into main Sep 19, 2023
1 check passed
@erikdrobne erikdrobne deleted the feature/optionally-attach-coordinator branch September 19, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skaggivara Skaggivara Skaggivara approved these changes

@tadelv tadelv Awaiting requested review from tadelv

Assignees

@erikdrobne erikdrobne

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikdrobne @Skaggivara