Skip to content
This repository has been archived by the owner on Apr 14, 2023. It is now read-only.

Avoid need for end-user to install Vale CLI #75

Open
apupier opened this issue Jul 14, 2022 · 0 comments · May be fixed by #92
Open

Avoid need for end-user to install Vale CLI #75

apupier opened this issue Jul 14, 2022 · 0 comments · May be fixed by #92

Comments

@apupier
Copy link
Contributor

apupier commented Jul 14, 2022

2 solutions:

  • Embed the CLI:
    ** It will avoid to ask user where it is installed.
    ** It is possible to provide platform-specific VS code extension. But as a first iteration given that the vale cli size is not that important (<7Mo), we can imagine to embed all of them in the extension.
    ** the drawback is that it requires to release VS code when a new release of vale cli is provided
  • Download CLI automatically when vale cli is onot available on classpath or provided through the settings
    ** ensures latest version of cli used
    ** harder to implement
    ** not working on airgapped environments
    ** if latest cli contains incompatible change, it will break the vs code extension
@apupier apupier changed the title Embed vale CLI Avoid need for end-user to install Vale CLI Jul 15, 2022
apupier added a commit to apupier/vale-vscode that referenced this issue Jul 29, 2022
apupier added a commit to apupier/vale-vscode that referenced this issue Jul 29, 2022
@apupier apupier linked a pull request Aug 5, 2022 that will close this issue
apupier added a commit to apupier/vale-vscode that referenced this issue Sep 2, 2022
apupier added a commit to apupier/vale-vscode that referenced this issue Sep 2, 2022
apupier added a commit to apupier/vale-vscode that referenced this issue Sep 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant