Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature simulation test #78

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Feature simulation test #78

wants to merge 13 commits into from

Conversation

albertNos
Copy link
Collaborator

featureNotebook -> featureSimulationTest

  • two tests that test constellation insertion by imitating simulationLoop and comparing to expected simulationSizes

  • out commented test descriptions/explanations

  • added distribution of IDs for Constellation satellites (1st Constellation from 1Million, 2nd from 2Million...)

@albertNos
Copy link
Collaborator Author

commit e7ca12c: build successful
commit d50505e: add constellation folders to tests/data -> build fails
locally the build works (as well as the test)
why?

@FG-TUM
Copy link
Collaborator

FG-TUM commented Dec 23, 2021

commit e7ca12c: build successful commit d50505e: add constellation folders to tests/data -> build fails locally the build works (as well as the test) why?

You can see the logs when you click on "Details" next to the failing Actions:

/home/runner/work/LADDS/LADDS/tests/testladds/SimulationTest.cpp:512:41: error: non-const lvalue reference to type 'ConfigReader' cannot bind to a value of unrelated type 'YAML::Node'
  auto autopas = simulation.initAutoPas(config);

Seems like you copy pasted the old tests that work with the plain YAML node and not the new ones that use the wrapper. Would be awesome if we could at some point squash all those tests to some generated test template to reduce code duplication and to avoid these kinds of problems.

@FG-TUM FG-TUM added the Constellations Anything related to constellations mechanics label Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Constellations Anything related to constellations mechanics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants