Improves the method synchronization safety

esa · Oct 24, 2023 · 68f98d2 · 68f98d2
1 parent df16966
commit 68f98d2
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/apis/api-mal/src/main/java/org/ccsds/moims/mo/mal/MALElementsRegistry.java b/apis/api-mal/src/main/java/org/ccsds/moims/mo/mal/MALElementsRegistry.java
@@ -42,7 +42,7 @@ public class MALElementsRegistry {
      * @param absoluteSFP The absolute short form part.
      * @param callable The method with the generation of the Element.
      */
-    public synchronized void addCallableElement(Long absoluteSFP, Callable<Element> callable) {
+    public void addCallableElement(Long absoluteSFP, Callable<Element> callable) {
         ELEMENTS.put(absoluteSFP, callable);
     }
 
@@ -149,15 +149,15 @@ public static Element elementListToElement(ElementList obj) throws NotFoundExcep
         }
     }
 
-    public void registerElementsForArea(MALArea malArea) {
+    public synchronized void registerElementsForArea(MALArea malArea) {
         Element[] elements = malArea.getElements();
 
         for (Element element : elements) {
             this.addCallableElement(element.getShortForm(), () -> element.createElement());
         }
     }
 
-    public void registerElementsForService(MALService malService) {
+    public synchronized void registerElementsForService(MALService malService) {
         Element[] elements = malService.getElements();
 
         for (Element element : elements) {