Reduces the verbosity of the error message

esa · Oct 20, 2023 · fe0d1a9 · fe0d1a9
1 parent 50e38e5
commit fe0d1a9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/mal-impl/src/main/java/esa/mo/mal/impl/MALReceiver.java b/mal-impl/src/main/java/esa/mo/mal/impl/MALReceiver.java
@@ -214,7 +214,7 @@ public void onMessage(final MALEndpoint callingEndpoint, MALMessage msg) {
             }
         } catch (MALInteractionException ex) {
             // try to determine address info if null
-            if (null == address) {
+            if (address == null) {
                 address = lookupAddress(callingEndpoint, msg);
             }
 

diff --git a/mal-impl/src/main/java/esa/mo/mal/impl/MALSender.java b/mal-impl/src/main/java/esa/mo/mal/impl/MALSender.java
@@ -604,11 +604,12 @@ private MALMessageBody initiateSynchronousInteraction(final Long transId,
                 throw new MALException("Return message was null!");
             }
 
-            // handle possible return error
+            // Case when we receive an Error message back on the return message:
             if (rtn.getHeader().getIsErrorMessage()) {
                 if (rtn.getBody() instanceof MALErrorBody) {
-                    MOErrorException error = ((MALErrorBody) rtn.getBody()).getError();
-                    MALContextFactoryImpl.LOGGER.log(Level.SEVERE,
+                    MALErrorBody errorBody = (MALErrorBody) rtn.getBody();
+                    MOErrorException error = errorBody.getError();
+                    MALContextFactoryImpl.LOGGER.log(Level.FINE,
                             "Something went wrong!", error);
                     throw new MALInteractionException(error);
                 }