fix: use tilde instead of caret for dependencies that could break CI #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 97.17% // Head: 97.17% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## beta #29 +/- ##
=======================================
Coverage 97.17% 97.17%
=======================================
Files 39 39
Lines 389 389
=======================================
Hits 378 378
Misses 11 11 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
🎉 This PR is included in version 15.0.0-beta.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 15.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm in dubio here, as using carets (
^) won't cause problems like mysticatea/eslint4b#14 (comment)On the other hand, CI will break once one of these packages release a minor update that includes adding/deprecating a rule, because we have scheduled workflow runs.
Tests will also fail once we update locally.
Since adding a new rule to a config is a breaking change (as it can cause more linting errors), I think it's OK to use tilde (
~) instead.@eslint-community/core-team @eslint-community/mysticatea-eslint-plugin WDYT about this?
Do you maybe have a better solution?