Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drop Node 12, 14 & 16 support #242

Merged

Conversation

MichaelDeBoey
Copy link
Member

BREAKING CHANGE: Requires Node@^18.18.0 || ^20.9.0 || >=21.1.0


Supersedes #234

Closes #232

@MichaelDeBoey MichaelDeBoey added the BREAKING CHANGE This change will require a major version bump label Oct 15, 2024
@MichaelDeBoey MichaelDeBoey requested review from voxpelli, scagood and a team October 15, 2024 15:51
@MichaelDeBoey MichaelDeBoey linked an issue Oct 15, 2024 that may be closed by this pull request
@MichaelDeBoey MichaelDeBoey self-assigned this Oct 15, 2024
Copy link

@scagood scagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💜

BREAKING CHANGE: Requires Node@^18.18.0 || ^20.9.0 || >=21.1.0
@MichaelDeBoey MichaelDeBoey force-pushed the drop-node-12-14-16-support branch from 08fe119 to cc5c18b Compare October 25, 2024 23:38
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.95%. Comparing base (5d65b26) to head (cc5c18b).
Report is 67 commits behind head on alpha.

Additional details and impacted files
@@            Coverage Diff             @@
##            alpha     #242      +/-   ##
==========================================
+ Coverage   95.84%   96.95%   +1.10%     
==========================================
  Files          12       13       +1     
  Lines         626     2102    +1476     
  Branches        0      397     +397     
==========================================
+ Hits          600     2038    +1438     
- Misses         26       63      +37     
- Partials        0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MichaelDeBoey MichaelDeBoey merged commit 8ffb50f into eslint-community:alpha Oct 26, 2024
14 checks passed
@MichaelDeBoey MichaelDeBoey deleted the drop-node-12-14-16-support branch October 26, 2024 03:04
Copy link

🎉 This PR is included in version 5.0.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE This change will require a major version bump hacktoberfest-accepted released on @alpha
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop older node versions from engines.node (align with ESLint 9?)
3 participants