Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Normal State, Fix C++ Compatibilty (AEGHB-337) #206

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

franz-ms-muc
Copy link
Contributor

Add Normal State, Fix C++ Compatibilty

@franz-ms-muc
Copy link
Contributor Author

@leeebo
i updated this to be in sync again with Master.

@CLAassistant
Copy link

CLAassistant commented Jun 2, 2023

CLA assistant check
All committers have signed the CLA.

@leeebo leeebo added the button label Aug 8, 2023
@leeebo
Copy link
Collaborator

leeebo commented Aug 8, 2023

Hi @franz-ms-muc sorry for the late response, Can you explain more about the application of this changes?

@github-actions github-actions bot changed the title Add Normal State, Fix C++ Compatibilty Add Normal State, Fix C++ Compatibilty (AEGHB-337) Aug 8, 2023
@lijunru-hub
Copy link
Contributor

Due to significant changes in the 'button' component at present, many of the modifications in the pull request are no longer applicable. As a result, this pull request will not be merged. Thank you very much for your contribution.

@franz-ms-muc
Copy link
Contributor Author

Hi @franz-ms-muc sorry for the late response, Can you explain more about the application of this changes?

Hi @leeebo i will close this one, and submit new, with splitted into several PRs to get clearer overview.

@franz-ms-muc
Copy link
Contributor Author

First one here: #327

@franz-ms-muc
Copy link
Contributor Author

the second one was already fixed by putting "usr_data" into a struct:

see: https://github.com/espressif/esp-iot-solution/blob/996917bc7674f2392d676539809e14951694055c/components/button/iot_button.c#L36C1-L40C20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants