Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support uvc multiple bulk transfer per sample #361

Merged

Conversation

leeebo
Copy link
Collaborator

@leeebo leeebo commented May 21, 2024

Related #360

@CLAassistant
Copy link

CLAassistant commented May 21, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

github-actions bot commented May 21, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello leeebo, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 45a952d

@leeebo
Copy link
Collaborator Author

leeebo commented May 22, 2024

sha=ebcc082a97b0a06aa07ee5893f9c1fb6ab56cd8e

@leeebo leeebo self-assigned this May 22, 2024
@leeebo leeebo requested a review from wujiangang May 22, 2024 06:12
@wujiangang
Copy link
Contributor

wujiangang commented May 22, 2024

sha=45a952d0418d0834062adf274bffbfa37ddafb47

@leeebo
Copy link
Collaborator Author

leeebo commented May 27, 2024

the github action should be fixed in espressif/sync-pr-to-gitlab#6

@leeebo leeebo force-pushed the feat/usb_stream_bulk_transfer branch from ebcc082 to 45a952d Compare June 3, 2024 00:50
@leeebo
Copy link
Collaborator Author

leeebo commented Jun 5, 2024

sha=45a952d0418d0834062adf274bffbfa37ddafb47

@zhanzhaocheng zhanzhaocheng merged commit 87a8c2e into espressif:master Jun 14, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants