Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(launchpad): change launchpad program (AEGHB-752) #387

Merged

Conversation

zhaoyunlong1234
Copy link
Contributor

change(launchpad): change launchpad program

Copy link

Warnings
⚠️ The Pull Request description looks very brief, please check if more details can be added.

👋 Hello zhaoyunlong1234, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 15dd07e

@github-actions github-actions bot changed the title change(launchpad): change launchpad program change(launchpad): change launchpad program (AEGHB-752) Jul 26, 2024
@lijunru-hub
Copy link
Contributor

@zhaoyunlong1234 不能 ReOpen 吗?#386

@leeebo leeebo self-requested a review July 29, 2024 03:31
@leeebo
Copy link
Collaborator

leeebo commented Jul 29, 2024

sha=15dd07e3ba6361043f71ecdfa9bf216c36dd990f

@zhanzhaocheng zhanzhaocheng merged commit 15dd07e into espressif:master Aug 2, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants