Merge pull request #235 from espressif/fix/automatic_release

fix: Fixed running called worflow only for chosen installer type
espressif · Mar 26, 2024 · c257c51 · c257c51
2 parents 8475fe1 + 74ebf8d
commit c257c51
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/.github/workflows/build-installer.yml b/.github/workflows/build-installer.yml
@@ -35,23 +35,23 @@ env:
 jobs:
     build-installer-online:
         name: Build Online Installer
-        if: ${{ github.env.INSTALLER_TYPE }} == 'online'
+        if: inputs.installer_type == 'online'
         uses: espressif/idf-installer/.github/workflows/build-online-installer.yml@main
         with:
             online_installer_version: ${{ inputs.online_installer_version }}
         secrets: inherit
 
     build-installer-offline:
         name: Build Offline Installer
-        if: ${{ github.env.INSTALLER_TYPE }} == 'offline'
+        if: inputs.installer_type == 'offline'
         uses: espressif/idf-installer/.github/workflows/build-offline-installer.yml@main
         with:
             esp_idf_version: ${{ inputs.esp_idf_version}}
         secrets: inherit
 
     build-installer-ide:
         name: Build IDE Installer
-        if: ${{ github.env.INSTALLER_TYPE }} == 'espressif-ide'
+        if: inputs.installer_type == 'espressif-ide'
         uses: espressif/idf-installer/.github/workflows/build-espressif-ide-installer.yml@main
         with:
             esp_idf_version: ${{ inputs.esp_idf_version }}

diff --git a/scripts/docs_update_release.py b/scripts/docs_update_release.py
@@ -160,7 +160,7 @@ def main():
     supported_idf_versions = eval(environ.get('SUPPORTED_IDF_VERSIONS', "('5.2', '4.4', '5.1', '5.0')"))    # e.g. ('5.2', '4.4', '5.1', '5.0')
     supported_idf_versions = list(supported_idf_versions)
 
-    if not idf_version:
+    if not idf_version and installer_type != 'online':
         raise SystemExit("ERROR: IDF version is not provided")
 
     # cast IDF version to list