-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/automatic installer release #222
Conversation
FYI @tomassebestik |
3faa687
to
c9b8915
Compare
…ed in download page
df7261b
to
76f4d7e
Compare
165d32f
to
f0a938e
Compare
f0a938e
to
dd687e8
Compare
scripts/docs_update_release.py
Outdated
return new_entry_online | ||
|
||
|
||
def update_index(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing tests
07e88f9
to
d45c881
Compare
@georgik I have implemented Jinja2 templating engine for changing (creating) the index.html. Also, other suggestions were improved. Can you please take a look at it? Here is the test PR created by the workflow: https://github.com/espressif/idf-installer/pull/233/files |
59c87ca
to
9100864
Compare
9100864
to
759f65d
Compare
759f65d
to
01ac791
Compare
I have added automatically assigned reviewers for PR and branch name with IDF version if there are multiple releases at the same time before the PR gets merged. Based on the in-person discussion, I am merging this. |
update-index
workflow is automatically triggered to update the download page with the releaseSuccessful workflow example: (espressif-ide installer)
Successful PR with installer release created by the workflow:
Automatic "release" mechanism explanation:
build-installer-any
workflow) is configured with all needed parameters (installer type
,ESP-IDF version
,IDE version
,Online installer version
(app version) ... not all parameters are needed every time)-- index.html:
Online installer
andIDE installer
are updated every timeOffline installer
is updated if theMAJOR
andMINOR
versions of ESP-IDF are already present in any buttonOffline installer
is not present in any button, a new button is created at the top (=> if the most top button of offline installers has version v5.2.1
and configured ESP-IDF version will be set to v5.3
, the new button will be added above this button)releases.json
is updated by adding the new installer release information as the first objectIdfToolsSetup.iss
is updated with the App or IDE versionupdate-index
workflow is automatically triggered and the download page is updated! WARNING - After this is merged, the original process of running installer build workflows will be changed (with the tag or manual run) => not backward compatible change