-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/hints viewer #1031
Feature/hints viewer #1031
Conversation
Download the artifacts for this pull request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few changes I think is need to make sure the code doesn't break like file exists and IDF version validation.
Add validations for: - file exist - yaml format - esp-idf version >= 5.0
@radurentea hi ! Tested:
|
Pull request has been marked as |
Hi @AndriiFilippov,
|
Pull request has been marked as |
@radurentea hi ! Create a "Hello World" project -> add string [#import "spiram.h"] -> build -> get error "spiram.h: No such file or directory" -> call "ESP-IDF: Search Error Hint" -> paste error message -> able to see hints command "ESP-IDF: Focus on Error Hints View" works fine 👍 LGTM 👍 |
- Now the hints update accordingly when changing files - Not focusing the hints viewer bottom panel if no hints found
Closing this PR because I've re-implemented this here: #1225 The reason is that the branch is too old and there are too many conflicts to solve. |
Description
Added Hints Viewer. Hints are provided in yaml file from esp-idf folder: /tools/idf_py_actions/hints.yml
Type of change
Please delete options that are not relevant.
Steps to test this pull request
Provide a list of steps to test changes in this PR and required output
Open ERROR HINTS bottom panel:
Press on "ESP-IDF: Search Error Hint"
Paste error in the top input that shows up
Hints shown in the panel
How has this been tested?
Followed the steps above on a windows OS.
Test Configuration:
Checklist