Chip-id in port selection (VSC-1359) #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @AndriiFilippov Please verify this |
github-actions
bot
changed the title
brianignacio5
requested changes
May 23, 2024
src/espIdf/serial/serialPort.ts
Outdated
| resolve(choices); | ||
| } else { | ||
| reject(new Error("No serial ports found")); | ||
| serialPort.chipType = chipIdString2[1].trim(); |
There was a problem hiding this comment.
Could we add validation that match exists and it has at least 2 elements here ?
|
@kolipakakondal @brianignacio5 hi ! Tested under: Do see chip info while multiple boards are connected.
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[## Description
Switcxhed serial port listing to node serialport and providing additional information about connected board chip ( if the board is ESP).
Type of change
Steps to test this pull request
Provide a list of steps to test changes in this PR and required output
Click on "Select port to use"
Wait for ~2 seconds
Observe results.
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Dependent components impacted by this PR:
Checklist