Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace $ sign for all strings and not only for the ones that don't have a new line. #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

issdn
Copy link

@issdn issdn commented Jul 25, 2024

Moved the replaceAll('\$', '\\\$') statement out of the if (!s.contains('\n')) so that $s in strings with a \n are also escaped.
Theoretically also raw strings could be used for these paragraphs which would save bit of performance I guess.

        if (!s.contains('\n')) {
          return 'r' + quote + s.replaceAll(quote, "\\$quote").replaceAll('\$', '\\\$') + quote;
        }
        final q3 = quote * 3;
        return 'r' + q3 + s.replaceAll(q3, '\\$quote' * 3) + q3;

Tested on the license of syncfusion_flutter_charts package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant