Replace $ sign for all strings and not only for the ones that don't have a new line. #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the
replaceAll('\$', '\\\$')
statement out of theif (!s.contains('\n'))
so that $s in strings with a\n
are also escaped.Theoretically also raw strings could be used for these paragraphs which would save bit of performance I guess.
Tested on the license of syncfusion_flutter_charts package.