Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tutorials and CI/CD stability #5005

Merged
merged 3 commits into from
Oct 18, 2024
Merged

Improve tutorials and CI/CD stability #5005

merged 3 commits into from
Oct 18, 2024

Conversation

jngrad
Copy link
Member

@jngrad jngrad commented Oct 15, 2024 •
edited
Loading

Closes #5004, closes #5006, closes #4998, closes #4997, closes #4996

Description of changes:

  • fix CI/CD pipeline issues
    • fix flaky Drude sample test (sample time step was too large)
    • select mpiexec flags based on the MPI vendor and Docker container
    • upgrade CPU and GPU resource allocation based on newly available hardware
  • fix regression in tools used to process tutorials during the summer school
    • solution Markdown cells can now be reversed back to solution code cells
  • improve tutorials based on summer school feedback

@jngrad
DevOps: Fix tutorial scripts and CI/CD
5fb1106 
Make the exercise/solution conversion script reversible.
Remove empty tutorial code cells.
@jngrad
docs: Improve tutorials
6ba8718 
Apply feedback from summer school participants and tutors: LB units
conversion, LB Mach number, non-standard LB symbols, broken links to
the user guide, better plot axis labels, automatically update ZnDraw
visualizer. Also remove the summer school banner.
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@jngrad jngrad force-pushed the tutorials branch 2 times, most recently from 978f02e to c8427cd Compare October 15, 2024 18:32
@jngrad jngrad marked this pull request as ready for review October 15, 2024 20:10
@jngrad jngrad requested a review from reinaual October 16, 2024 09:07
@jngrad jngrad added the automerge Merge with kodiak label Oct 18, 2024
@kodiakhq kodiakhq bot merged commit f73f0f5 into espressomd:python Oct 18, 2024
10 checks passed
@jngrad jngrad deleted the tutorials branch October 18, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reinaual reinaual reinaual approved these changes

@RudolfWeeber RudolfWeeber Awaiting requested review from RudolfWeeber

Assignees
No one assigned
Labels
automerge Merge with kodiak DevOps Documentation
Projects
None yet
Milestone
No milestone
2 participants
@jngrad @reinaual