Working AT driver for MC7455 and EM7590, not tested with anything else #139
Conversation
|
Reverted long usage in logic_channel_open interface as we always should return 0. Hope now it builds on all platforms |
| /* AT+CGLA=? might not be available but AT+CGLA= is | ||
| Sierra wireless MC7455 supports both but EM7590 only the latter | ||
| fprintf(fuart, "AT+CGLA=?\r\n"); | ||
| if (at_expect(NULL, NULL)) | ||
| { | ||
| fprintf(stderr, "Device missing AT+CGLA support\n"); | ||
| return -1; | ||
| } | ||
|
|
||
| */ |
There was a problem hiding this comment.
If you remove the check on AT+CGLA=? because it doesn't work, you should add a check on AT+CGLA= or do some error handling when using AT+CGLA=.
There was a problem hiding this comment.
I don't think it is that important to be honest, it will just fail after the first command, checking for AT+CGLA= requires to actually do AT+CCHO and then AT+CGLA so what are we gaining here.
Maybe change it to a warning? and again the issue is the lack of AT+CGLA= and not AT+CGLA=? where in AT commands those are separated commands so just like in the case of sierra wireless it might not be implemented
| @@ -106,7 +109,7 @@ static int apdu_interface_transmit(struct euicc_ctx *ctx, uint8_t **rx, uint32_t | |||
| return -1; | |||
| } | |||
|
|
|||
| fprintf(fuart, "AT+CGLA=%d,%u,\"", logic_channel, tx_len * 2); | |||
| fprintf(fuart, "AT+CGLA=%lx,%u,\"", logic_channel, tx_len * 2); | |||
There was a problem hiding this comment.
| fprintf(fuart, "AT+CGLA=%lx,%u,\"", logic_channel, tx_len * 2); | |
| fprintf(fuart, "AT+CGLA=%" PRIu ",%u,\"", logic_channel, tx_len * 2); |
If you choose to use fixed-width integer type.
|
|
||
| return logic_channel; | ||
| logic_channel = strtol(response, NULL, 16); |
There was a problem hiding this comment.
| logic_channel = strtol(response, NULL, 16); | |
| logic_channel = strtoull(response, NULL, 16); |
Same as above.
| @@ -198,7 +207,7 @@ static void apdu_interface_logic_channel_close(struct euicc_ctx *ctx, uint8_t ch | |||
| { | |||
| return; | |||
| } | |||
| fprintf(fuart, "AT+CCHC=%d\r\n", logic_channel); | |||
| fprintf(fuart, "AT+CCHC=%lx\r\n", logic_channel); | |||
There was a problem hiding this comment.
| fprintf(fuart, "AT+CCHC=%lx\r\n", logic_channel); | |
| fprintf(fuart, "AT+CCHC=%" PRIu "\r\n", logic_channel); |
Same as above.
Co-authored-by: Coelacanthus <CoelacanthusHex@gmail.com>
Seems like with sierra wireless there are 3 issues with the existing AT code:
see: AT command APDU driver violates 3GPP TS 27.007 and will not work on e.g. MC7455 #138 for explanation
The following code was only tested with MC7455 and EM7590. tested with esim.me sim and sysmocom (https://shop.sysmocom.de/sysmoEUICC1-eUICC-for-consumer-eSIM-RSP/sysmoEUICC1-C2G)