Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add version applet #53

Merged
merged 2 commits into from
Mar 16, 2024
Merged

add version applet #53

merged 2 commits into from
Mar 16, 2024

Conversation

septs
Copy link
Contributor

@septs septs commented Mar 16, 2024 •
edited
Loading 

$ ./lpac version | jq
{
  "type": "lpa",
  "payload": {
    "code": 0,
    "message": "success",
    "data": "v2.0.0-alpha.3-6-ge324419-dirty"
  }
}

estkme
estkme reviewed Mar 16, 2024
View reviewed changes
src/applet/version.c

static int applet_main(int argc, char **argv)
{
jprint_success(cJSON_CreateString(LPAC_VERSION));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议用IFNDEF检查一下如果没有定义就输出unknown，不要依赖cmake

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved

@estkme estkme merged commit 4f725f9 into estkme-group:main Mar 16, 2024
6 checks passed
@septs septs deleted the version-applet branch May 3, 2024 08:48
ocd0711 pushed a commit to ocd0711/lpac that referenced this pull request May 7, 2024
@septs @ocd0711
add version applet (estkme-group#53)
7963613 
* add version applet

* accpet review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estkme estkme estkme left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@septs @estkme