Move drivers into libeuicc-drivers.so
#59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for reuse from projects dynamically linked to libeuicc. Note that we don't reintroduce dlopen() based drivers here. All backends except stdio have been made optional using CMake options. C-side macros in driver.c have been adjusted to always mean enabling the corresponding backend when defined. Note that the GBinder backend does not need to distinguish between the current HIDL version and a future AIDL implementation. Both will have the same dependencies and will probably fall back on to each other automatically.
Also separate lpac_driver struct from the installed version
This is needed by github actions
ocd0711
pushed a commit
to ocd0711/lpac
that referenced
this pull request
May 7, 2024
* Move drivers back to their own (optionally dynamic) This allows for reuse from projects dynamically linked to libeuicc. Note that we don't reintroduce dlopen() based drivers here. All backends except stdio have been made optional using CMake options. C-side macros in driver.c have been adjusted to always mean enabling the corresponding backend when defined. Note that the GBinder backend does not need to distinguish between the current HIDL version and a future AIDL implementation. Both will have the same dependencies and will probably fall back on to each other automatically. * Set up installed headers and pkg-config for libeuicc-drivers.so Also separate lpac_driver struct from the installed version * Namespace all exposed symbols in libeuicc-drivers.so * Add back output directory config This is needed by github actions * curl is dlopen()'d on Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name prefix
libeuiccis chosen because they really relate more tolibeuiccthan tolpac. The only thing these drivers do that's not inlibeuiccis theirmain()entry points. For now,libeuicc-drivers.sowill simply expose those main functions as variables that get set at load time -- it no longer depends on the applet struct from lpac. A downstream project could conceivably use these main functions in a completely different way thanlpac.All drivers have been made optional (except
stdio) with their own corresponding CMake variables. See commit descriptions for details.