fixed precedence of sequence expression in computed property name (#415)

Co-authored-by: sanex3339 <yarabotayuvyandex3339>
estools · Jun 22, 2020 · eee573b · eee573b
1 parent 177ec89
commit eee573b
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 1 deletion.
diff --git a/escodegen.js b/escodegen.js
@@ -983,7 +983,7 @@
             result.push('[');
         }
 
-        result.push(this.generateExpression(expr, Precedence.Sequence, E_TTT));
+        result.push(this.generateExpression(expr, Precedence.Assignment, E_TTT));
 
         if (computed) {
             result.push(']');

diff --git a/test/compare-acorn-es6/class-declaration.expected.js b/test/compare-acorn-es6/class-declaration.expected.js
@@ -0,0 +1,12 @@
+class ComputedKey {
+    [n1 + n2]() {
+    }
+}
+class AssignmentExpressionAsKey {
+    [n1 = n2]() {
+    }
+}
+class SequenceExpressionAsKey {
+    [(n1, n2)]() {
+    }
+}
diff --git a/test/compare-acorn-es6/class-declaration.expected.min.js b/test/compare-acorn-es6/class-declaration.expected.min.js
@@ -0,0 +1 @@
+class ComputedKey{[n1+n2](){}}class AssignmentExpressionAsKey{[n1=n2](){}}class SequenceExpressionAsKey{[(n1,n2)](){}}
diff --git a/test/compare-acorn-es6/class-declaration.js b/test/compare-acorn-es6/class-declaration.js
@@ -0,0 +1,9 @@
+class ComputedKey {
+    [n1 + n2]() {}
+}
+class AssignmentExpressionAsKey {
+    [n1 = n2]() {}
+}
+class SequenceExpressionAsKey {
+    [(n1, n2)]() {}
+}
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		class ComputedKey{[n1+n2](){}}class AssignmentExpressionAsKey{[n1=n2](){}}class SequenceExpressionAsKey{[(n1,n2)](){}}