Évolutions v0.3.0 : suppression id_lieu, id_local devient obligatoire #29
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment. Ahah j'avais oublié que j'avais fait les fichiers d'exemples de ce schéma |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| id_local,nom_lieu,ad_lieu,com_lieu,insee,type,date_maj,ouvert,source,Xlong,Ylat,nbre_pl,nbre_pmr,duree,horaires,proprio,lumiere,comm | ||
| 23X01,Gare SNCF de Dieppe,2 Boulevard Georges Clemenceau,Dieppe,76217,Parking,2019-06-25,true,217602176,1.081183,49.921823,20,2,,true,Ville de Dieppe,true,Correspondance avec la ligne TER Dieppe-Rouen | ||
| 23X02,Gare Routière de Dieppe,2 Avenue Victor Louis,Dieppe,76000,Parking,24-06-2019,true,576578587,49.921921,1.065656,2,3,,false,Ville de Dieppe,true,Proximité de la gare SNCF |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| id_local,nom_lieu,ad_lieu,com_lieu,insee,type,date_maj,ouvert,source,Xlong,Ylat,nbre_pl,nbre_pmr,duree,horaires,proprio,lumiere,comm | ||
| 23X01,Gare SNCF de Dieppe,2 Boulevard Georges Clemenceau,Dieppe,76217,Parking,2019-06-25,true,217602176,1.081183,49.921823,20,2,,true,Ville de Dieppe,true,"Correspondance avec la ligne TER Dieppe-Rouen" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,19 +19,19 @@ | |
| { | ||
| "title": "Ressource valide", | ||
| "name": "exemple-valide", | ||
| "path": "https://github.com/etalab/schema-lieux-covoiturage/raw/v0.3.0/exemple-valide.csv" | ||
| }, | ||
| { | ||
| "title": "Ressource invalide", | ||
| "name": "exemple-invalide", | ||
| "path": "https://github.com/etalab/schema-lieux-covoiturage/raw/v0.3.0/exemple-invalide.csv" | ||
|
Comment on lines
+22
to
+27
There was a problem hiding this comment. @AurelienC J'ai ajouté ceci There was a problem hiding this comment. On s'était posé la question : pourquoi mettre l'url "en dur" vers la version plutôt que de pointer vers la dernière version via "raw" ? There was a problem hiding this comment. Vers la dernière version à chaque fois tu veux dire ? Pour que les précédentes versions des schémas maintiennent des liens valides et cohérents avec le contenu de Mais sans ça le fichier d'exemple ne correspond pas au schéma potentiellement pour les versions précédentes |
||
| } | ||
| ], | ||
| "author":"Antoine Augusti pour Etalab", | ||
| "contact":"contact@transport.beta.gouv.fr", | ||
| "contributors": [ | ||
| { | ||
| "title": "Miryad Ali, Francis Chabouis, Aurélien Cadiou", | ||
| "email": "contact@transport.beta.gouv.fr", | ||
AurelienC marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "organisation": "transport.data.gouv.fr", | ||
| "role": "contributor" | ||
|
|
@@ -73,30 +73,20 @@ | |
| "role": "contributor" | ||
| } | ||
| ], | ||
| "version":"0.3.0", | ||
| "created":"2019-06-25", | ||
| "lastModified":"2023-09-01", | ||
| "homepage":"https://github.com/etalab/schema-lieux-covoiturage", | ||
| "uri":"https://github.com/etalab/lieux-covoiturage/blob/master/schema.json", | ||
| "example":"https://github.com/etalab/lieux-covoiturage/blob/master/exemple-valide.csv", | ||
| "fields":[ | ||
| { | ||
| "name":"id_local", | ||
| "description":"Identifiant du lieu de covoiturage fixé par le producteur de la donnée pour son propre usage", | ||
| "example":"23X01", | ||
| "type":"string", | ||
| "constraints":{ | ||
| "required":true | ||
| } | ||
| }, | ||
| { | ||
|
|
@@ -288,6 +278,5 @@ | |
| ], | ||
| "missingValues":[ | ||
| "" | ||
|
Comment on lines
-291
to
-292
There was a problem hiding this comment. Retirer la clé primaire. |
||
| ] | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je dirais que c'est inutile en cas de dépôt/remplacement de fichiers sur data.gouv.fr. Peut-être faire un tour sur le README et harmoniser avec la doc côté PAN ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Qu'est-ce qui est inutile @AntoineAugusti , de définir le séparateur ou d'insérer toutes les colonnes même vides ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je parlais du paragraphe qui aborde la convention de nommage à respecter pour le fichier.