Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing calls for AccessEvents #415

Open
wants to merge 1 commit into
base: optimism
Choose a base branch
from
Open

add missing calls for AccessEvents #415

wants to merge 1 commit into from
+8 −0

Conversation

zhiqiangxu
Copy link
Contributor

@zhiqiangxu zhiqiangxu commented Oct 27, 2024 •
edited
Loading

There's already such code for Coinbase here:

// add the coinbase to the witness iff the fee is greater than 0
if rules.IsEIP4762 && fee.Sign() != 0 {
	st.evm.AccessEvents.AddAccount(st.evm.Context.Coinbase, true)
}

This PR adds the missing calls to AccessEvents for OptimismBaseFeeRecipient and OptimismL1FeeRecipient.

@zhiqiangxu zhiqiangxu requested a review from a team as a code owner October 27, 2024 03:50
@zhiqiangxu zhiqiangxu requested a review from tynes October 27, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tynes tynes Awaiting requested review from tynes tynes is a code owner automatically assigned from ethereum-optimism/op-geth-maintainers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zhiqiangxu