Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI Linting & Typecheck #12

Merged
merged 3 commits into from
Nov 20, 2024
Merged

CLI Linting & Typecheck #12

merged 3 commits into from
Nov 20, 2024

Conversation

nitaliano
Copy link
Collaborator

@nitaliano nitaliano commented Nov 20, 2024 •
edited
Loading

Description

  • Adds cargo workspaces so we can have a top level Cargo.lock to help us generate a checksum as a cache key in CI
  • Adds typescript CI check
  • Adds oxlint to CLI and adds CI check

All of the checks are optional for right now

@nitaliano nitaliano marked this pull request as ready for review November 20, 2024 23:48
@nitaliano nitaliano requested a review from a team as a code owner November 20, 2024 23:48
@nitaliano nitaliano requested review from tremarkley and removed request for a team November 20, 2024 23:48
@nitaliano nitaliano merged commit 8c9c30b into main Nov 20, 2024
2 of 3 checks passed
@nitaliano nitaliano deleted the cli-lint-typecheck branch November 20, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tremarkley tremarkley Awaiting requested review from tremarkley tremarkley is a code owner automatically assigned from ethereum-optimism/ecosystem

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nitaliano