Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]feat: add snapshot multiversion cache #30073

Closed

Conversation

will-2012
Copy link

@will-2012 will-2012 commented Jun 26, 2024

This is just a draft implementation which refers to #30022.

@will-2012 will-2012 changed the title feat: add snapshot multiversion cache [WIP]feat: add snapshot multiversion cache Jun 26, 2024
@will-2012 will-2012 marked this pull request as draft June 26, 2024 09:35
@rjl493456442
Copy link
Member

--- FAIL: TestMergeDelete (0.00s)
    difflayer_test.go:164: last diff layer: expected 0000000000000000000000000000000000000000000000000000000000000001 account to be non-nil
    difflayer_test.go:179: merged layer: expected 0000000000000000000000000000000000000000000000000000000000000001 account to be non-nil
--- FAIL: TestInsertAndMerge (0.00s)
    difflayer_test.go:231: merged slot value wrong: have , want 01
--- FAIL: TestPostCapBasicDataAccess (0.00s)
    snapshot_test.go:318: expected error, got data &{bceb478c0bb93ee9 6883976a232b6995 208db347742edae8100376466c241dfae728170eec959988352f2698a4916919 c5d2460186f7233c927e7db2dcc703c0e500b653ca82273b7bfad8045d85a470}
FAIL
FAIL	github.com/ethereum/go-ethereum/core/state/snapshot	7.427s
?   	github.com/ethereum/go-ethereum/core/stateless	[no test files]

Several tests are failing on CI.

@will-2012
Copy link
Author

Mark down:

  1. The snapshot access volume is 1/6 of the trie access volume;
  2. The current multiversion resorted is too time-consuming;

Temporarily abandon the PR and think about a better implementation.

@will-2012 will-2012 closed this Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants